Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy update: /careers/company-culture #1461

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

jasmine-canonical
Copy link
Contributor

@jasmine-canonical jasmine-canonical commented Dec 12, 2024

Done

  • Updates /careers/company-culture to changes some numbers and switch from British to American English

QA

Issue / Card

Fixes WD-17731

@webteam-app
Copy link

@jasmine-canonical
Copy link
Contributor Author

I noticed that the changes made to switch from British to American English were inconsistent (ex. some of the "organisation" words were changed to "organization" while others were left as is). Please let me know if you'd like for me to change those as well, or if that'll be left for a different copy update.

@fasih-mehmood
Copy link
Contributor

fasih-mehmood commented Dec 17, 2024

I noticed that the changes made to switch from British to American English were inconsistent (ex. some of the "organisation" words were changed to "organization" while others were left as is). Please let me know if you'd like for me to change those as well, or if that'll be left for a different copy update.

I believe these should be replaced as well. I've added comments in the copy doc and tagged you @jasmine-canonical, so lets hold off on merging this until Gloria responds.

Thank you!

Edit: Gloria replied on the copy doc. Please include these changes.

@jasmine-canonical
Copy link
Contributor Author

I believe these should be replaced as well.

@fasih-mehmood the additional changes have been included! Please let me know if it's ok to merge now.

@fasih-mehmood
Copy link
Contributor

I believe these should be replaced as well.

@fasih-mehmood the additional changes have been included! Please let me know if it's ok to merge now.

Thank you @jasmine-canonical, you are cleared for landing! ✈️

@jasmine-canonical jasmine-canonical merged commit 27e225c into main Dec 19, 2024
9 checks passed
@jasmine-canonical jasmine-canonical deleted the update-company-culture branch December 19, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants